Skip to content

Bump pre-commit deps, to fix a breaking Click update#590

Merged
DiddiLeija merged 5 commits intowntrblm:mainfrom
DiddiLeija:black-and-click
Apr 1, 2022
Merged

Bump pre-commit deps, to fix a breaking Click update#590
DiddiLeija merged 5 commits intowntrblm:mainfrom
DiddiLeija:black-and-click

Conversation

@DiddiLeija
Copy link
Copy Markdown
Collaborator

@DiddiLeija DiddiLeija commented Mar 28, 2022

This fixes an issue with a breaking Click update.

See psf/black#2964 for full details.

@DiddiLeija
Bump black from 22.1.0 to 22.3.0
e5c0fe8 
This fixes an issue with a breaking Click update.
@DiddiLeija DiddiLeija changed the title Bump black from 22.1.0 to 22.3.0 Bump black from 22.1.0 to 22.3.0 on pre-commit Mar 28, 2022
@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 28, 2022 •
edited
Loading

Ah... this crashed with something I didn't expect... pycln:

Details 
pycln....................................................................Failed
- hook id: pycln
- exit code: 1

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/bin/pycln", line 5, in <module>
    from pycln.cli import app
  File "/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/lib/python3.9/site-packages/pycln/__init__.py", line 7, in <module>
    import typer
  File "/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/lib/python3.9/site-packages/typer/__init__.py", line 12, in <module>
    from click.termui import get_terminal_size as get_terminal_size
ImportError: cannot import name 'get_terminal_size' from 'click.termui' (/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/lib/python3.9/site-packages/click/termui.py)
Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/bin/pycln", line 5, in <module>
    from pycln.cli import app
  File "/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/lib/python3.9/site-packages/pycln/__init__.py", line 7, in <module>
    import typer
  File "/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/lib/python3.9/site-packages/typer/__init__.py", line 12, in <module>
    from click.termui import get_terminal_size as get_terminal_size
ImportError: cannot import name 'get_terminal_size' from 'click.termui' (/home/runner/.cache/pre-commit/repo4hw2hs9j/py_env-python3/lib/python3.9/site-packages/click/termui.py)

@DiddiLeija DiddiLeija changed the title Bump black from 22.1.0 to 22.3.0 on pre-commit Bump pre-commit deps, to fix a breaking Click update Mar 28, 2022
@DiddiLeija
Bump pycln from 1.1.0 to 1.2.5
f4409d0 
I hope this will fix the last Click incompatibility.
@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 28, 2022

Ah, I don't think upgrading pcln will fix anything... Maybe we should keep click pinned, to avoid issues.

Any thoughts @wntrblm/nox 1?

Footnotes

  1. Small note: I didn't expect this to be a big issue to fix, but seems like I had to open an issue first. Sorry :/ ↩

@DiddiLeija DiddiLeija closed this Mar 28, 2022
@DiddiLeija DiddiLeija deleted the black-and-click branch March 28, 2022 20:23
@DiddiLeija DiddiLeija restored the black-and-click branch March 28, 2022 20:24
@DiddiLeija DiddiLeija reopened this Mar 28, 2022
@DiddiLeija DiddiLeija mentioned this pull request Mar 28, 2022
Closed
@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 28, 2022

Ok, I reported this at hadialqattan/pycln#116. By now, I'll try to reduce Click to a lower version for running pycln.

@DiddiLeija
Pin click to 8.0.4 for pycln
accb3d6 
This could be a temporary solution to the pycln issue.
@henryiii
Copy link
Copy Markdown
Collaborator

henryiii commented Mar 28, 2022 •
edited
Loading

You can fix it by adding a cap on click inside the pycln environment. See https://github.com/pybind/pybind11/pull/3831/files. It's actually typer's fault in fastapi/typer#377, not pycln.

@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 28, 2022

Good to hear that, thanks @henryiii!

@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 28, 2022

I think this is ready now.

@DiddiLeija DiddiLeija requested a review from a team March 29, 2022 15:41
@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 30, 2022

I see that Typer will get fixed soon (fastapi/typer#380). So, I think we can remove the Click downgrading and just upgrade some deps :)

@henryiii
Copy link
Copy Markdown
Collaborator

henryiii commented Mar 30, 2022

27 minutes ago, yes. :)

henryiii
henryiii reviewed Mar 30, 2022
View reviewed changes
@tiangolo
Copy link
Copy Markdown

tiangolo commented Mar 30, 2022

I just released Typer 0.4.1 that should handle it. 🚀 🤓

@DiddiLeija
Remove the pycln patch
8f8ef7b 
Typer has just fixed its issue :)
@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Mar 30, 2022

All done :)

@DiddiLeija
Copy link
Copy Markdown
Collaborator Author

DiddiLeija commented Apr 1, 2022

I'm gonna merge this, since it looks like nobody disagrees :D

@DiddiLeija DiddiLeija merged commit 0fd600f into wntrblm:main Apr 1, 2022
@DiddiLeija DiddiLeija deleted the black-and-click branch April 11, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DiddiLeija @henryiii @tiangolo